Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update data files release script #454

Merged
merged 1 commit into from
May 5, 2021

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented May 3, 2021

FYI @shanosborne @kjbrooks

Update data files release script to

  1. Include the 1024 and 2048-sized pupil files in the minimal data zip we use for Travis CI, while still exclude the larger files
  2. Update the master script for where the files should go after being created.

@mperrin mperrin requested a review from shanosborne May 3, 2021 20:40
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #454 (39d28fb) into develop (ddaf6c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #454   +/-   ##
========================================
  Coverage    63.14%   63.14%           
========================================
  Files           11       11           
  Lines         4393     4393           
========================================
  Hits          2774     2774           
  Misses        1619     1619           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddaf6c0...39d28fb. Read the comment docs.

@mperrin mperrin mentioned this pull request May 3, 2021
5 tasks
Copy link
Contributor

@shanosborne shanosborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mperrin mperrin merged commit 9263cc7 into spacetelescope:develop May 5, 2021
@mperrin mperrin deleted the update-datafiles-script branch November 18, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants