Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MIRI detector scale params to match current SIAF #456

Merged

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented May 10, 2021

Minor but significant: Update MIRI pixel scale and rotation to match current SIAF.

No change in values for other SIs (but I update the comment text to state the SIAF version)

@mperrin mperrin added the JWST Affects JWST models in WebbPSF label May 10, 2021
@mperrin mperrin requested a review from shanosborne May 10, 2021 23:17
@mperrin mperrin self-assigned this May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #456 (cfe2669) into develop (6a4b30f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #456   +/-   ##
========================================
  Coverage    63.21%   63.21%           
========================================
  Files           11       11           
  Lines         4401     4401           
========================================
  Hits          2782     2782           
  Misses        1619     1619           
Impacted Files Coverage Δ
webbpsf/webbpsf_core.py 81.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a4b30f...cfe2669. Read the comment docs.

@mperrin
Copy link
Collaborator Author

mperrin commented Jun 2, 2021

ping @shanosborne for a review on this one (should be very quick!)

Copy link
Contributor

@shanosborne shanosborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mperrin mperrin merged commit 5cdd41e into spacetelescope:develop Jun 3, 2021
@mperrin mperrin deleted the update_pixelscale_prdopsoc-031 branch November 6, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JWST Affects JWST models in WebbPSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants