-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.6 #498
Remove Python 3.6 #498
Conversation
docs/installation.rst
Outdated
@@ -105,7 +105,7 @@ Software Requirements | |||
|
|||
See `the environment.yml specification file <https://github.com/spacetelescope/webbpsf/blob/develop/environment.yml>`_ for the required package dependencies. | |||
|
|||
**Required Python version**: WebbPSF 0.9.1 and above require Python 3.6 or higher. | |||
**Required Python version**: WebbPSF 0.9.2 and above require Python 3.7 or higher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: this can be "WebbPSF 1.0 and above"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov Report
@@ Coverage Diff @@
## develop #498 +/- ##
========================================
Coverage 62.86% 62.86%
========================================
Files 11 11
Lines 4616 4616
========================================
Hits 2902 2902
Misses 1714 1714
Continue to review full report at Codecov.
|
Changing the minimum supported python version from 3.6 to 3.7. Also switching a few tests in github actions to python 3.9.