Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.6 #498

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Conversation

shanosborne
Copy link
Contributor

Changing the minimum supported python version from 3.6 to 3.7. Also switching a few tests in github actions to python 3.9.

@@ -105,7 +105,7 @@ Software Requirements

See `the environment.yml specification file <https://github.com/spacetelescope/webbpsf/blob/develop/environment.yml>`_ for the required package dependencies.

**Required Python version**: WebbPSF 0.9.1 and above require Python 3.6 or higher.
**Required Python version**: WebbPSF 0.9.2 and above require Python 3.7 or higher.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: this can be "WebbPSF 1.0 and above"

Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #498 (fbeffcf) into develop (b32536c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #498   +/-   ##
========================================
  Coverage    62.86%   62.86%           
========================================
  Files           11       11           
  Lines         4616     4616           
========================================
  Hits          2902     2902           
  Misses        1714     1714           
Impacted Files Coverage Δ
webbpsf/__init__.py 96.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32536c...fbeffcf. Read the comment docs.

@shanosborne shanosborne merged commit dbc630f into spacetelescope:develop Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants