Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-145] require Python 3.10 #817

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

zacharyburnett
Copy link
Contributor

resolves SCSB-145

propagate Astropy's deprecation of Python 3.9 to downstream packages

Note

this PR was generated automatically by batchpr 🤖

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.58%. Comparing base (63f7231) to head (fc2b68c).
Report is 2 commits behind head on develop.

❗ Current head fc2b68c differs from pull request most recent head 9e2d170. Consider uploading reports for the commit 9e2d170 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #817   +/-   ##
========================================
  Coverage    60.58%   60.58%           
========================================
  Files           16       16           
  Lines         6649     6649           
========================================
  Hits          4028     4028           
  Misses        2621     2621           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as draft March 14, 2024 18:32
@zacharyburnett zacharyburnett marked this pull request as ready for review March 15, 2024 19:44
@BradleySappington
Copy link
Collaborator

Thanks @zacharyburnett, I think that tox.ini and ci_workflows should be updated as well with this PR? The latter is causing errors trying to install '3.1' which is peculiar...

@BradleySappington
Copy link
Collaborator

@zacharyburnett - looks like tox still has references to 3.9 and can be moved from 3.10 - 3.12 in the environment setups.
Also pyproject.toml will probably need numpy >=1.21.6

@mperrin
Copy link
Collaborator

mperrin commented Mar 27, 2024

@BradleySappington @zacharyburnett - I wanted to check in for a status on this PR? It would be nice to get this merged in soon if possible, since the py3.9 lack of support is causing test failures for other PRs at this point. Thanks!

python 3.10 is now our legacy and 3.12 is now our latest
@zacharyburnett
Copy link
Contributor Author

zacharyburnett commented Mar 28, 2024

@BradleySappington @zacharyburnett - I wanted to check in for a status on this PR? It would be nice to get this merged in soon if possible, since the py3.9 lack of support is causing test failures for other PRs at this point. Thanks!

I apologize! I have been occupied by the JWST pipeline release and regression tests; these commits look good to me!

Legacy numpy can be 1.21.6
@BradleySappington BradleySappington merged commit 1d3e016 into spacetelescope:develop Mar 28, 2024
7 checks passed
@mperrin
Copy link
Collaborator

mperrin commented Mar 28, 2024

Thank you both!

And no worries, no need to apologize @zacharyburnett. I completely sympathize on having too many things to be occupied with, ha. All too often...

@zacharyburnett zacharyburnett deleted the scsb145 branch March 28, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants