#839 Visit Id naming smarts in get_visit_nrc_ta_image

[kulpster85]

#839 - add robustness to the visitid formatting to replace a "V" if present and otherwise ignore

[pep8speaks]

Hello @kulpster85, Thank you for submitting the Pull Request !

• In the file webbpsf/mast_wss.py:

Line 18:1: E266 too many leading '#' for block comment
Line 47:72: E703 statement ends with a semicolon
Line 61:1: E266 too many leading '#' for block comment
Line 86:9: E265 block comment should start with '# '
Line 91:27: E226 missing whitespace around arithmetic operator
Line 104:23: E226 missing whitespace around arithmetic operator
Line 105:23: E701 multiple statements on one line (colon)
Line 113:27: E701 multiple statements on one line (colon)
Line 204:19: E701 multiple statements on one line (colon)
Line 208:19: E701 multiple statements on one line (colon)
Line 212:19: E701 multiple statements on one line (colon)
Line 218:9: E122 continuation line missing indentation or outdented
Line 219:19: E701 multiple statements on one line (colon)
Line 221:57: E251 unexpected spaces around keyword / parameter equals
Line 221:59: E251 unexpected spaces around keyword / parameter equals
Line 225:1: E266 too many leading '#' for block comment
Line 225:1: E303 too many blank lines (3)
Line 227:1: E302 expected 2 blank lines, found 3
Line 298:1: E266 too many leading '#' for block comment
Line 374:1: E302 expected 2 blank lines, found 1
Line 384:13: E128 continuation line under-indented for visual indent
Line 392:1: E302 expected 2 blank lines, found 1
Line 462:5: E265 block comment should start with '# '
Line 463:5: E265 block comment should start with '# '
Line 469:33: E231 missing whitespace after ','
Line 477:5: E265 block comment should start with '# '
Line 483:23: E701 multiple statements on one line (colon)
Line 493:23: E701 multiple statements on one line (colon)
Line 558:40: E701 multiple statements on one line (colon)
Line 590:25: E203 whitespace before ':'
Line 590:39: E203 whitespace before ':'
Line 592:1: E302 expected 2 blank lines, found 1
Line 632:9: E123 closing bracket does not match indentation of opening bracket's line
Line 697:13: E126 continuation line over-indented for hanging indent
Line 697:47: E261 at least two spaces before inline comment
Line 699:12: E126 continuation line over-indented for hanging indent
Line 703:5: E303 too many blank lines (3)
Line 705:11: E128 continuation line under-indented for visual indent
Line 706:10: E124 closing bracket does not match visual indentation
Line 739:5: E303 too many blank lines (3)
Line 765:24: E231 missing whitespace after ':'
Line 769:17: E124 closing bracket does not match visual indentation
Line 777:5: E303 too many blank lines (2)
Line 777:41: E231 missing whitespace after ','
Line 789:5: E303 too many blank lines (2)
Line 792:28: E201 whitespace after '('
Line 792:33: E226 missing whitespace around arithmetic operator
Line 794:16: E225 missing whitespace around operator
Line 797:1: E302 expected 2 blank lines, found 1
Line 797:39: E241 multiple spaces after ','
Line 822:5: E303 too many blank lines (2)
Line 823:13: E225 missing whitespace around operator
Line 826:5: E265 block comment should start with '# '

If you have not done so, please lint your code in accordance with best practices.

[mperrin]

Tested and working as intended.

With this, both the following work equally well, yielding the same output without error.

webbpsf.trending.nrc_ta_image_comparison('V04503091001')
webbpsf.trending.nrc_ta_image_comparison('04503091001')

[mperrin]

Fixed #839.