Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test function for the NIRCam DHS support. #857

Merged
merged 2 commits into from
May 22, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented May 21, 2024

Add a unit test for the DHS support added in #845

This tests that we can select one of the DHS sub apertures as a pupil mask, make a PSF, and that the resulting PSF has only a couple percent of the total intensity (as expected, given the small size of these sub apertures)

@pep8speaks
Copy link

pep8speaks commented May 21, 2024

Hello @mperrin, Thank you for updating !

Line 26:1: E302 expected 2 blank lines, found 1
Line 29:1: E302 expected 2 blank lines, found 1
Line 32:1: E302 expected 2 blank lines, found 1
Line 35:1: E302 expected 2 blank lines, found 1
Line 36:11: E271 multiple spaces after keyword
Line 37:17: E126 continuation line over-indented for hanging indent
Line 38:13: E126 continuation line over-indented for hanging indent
Line 40:1: E302 expected 2 blank lines, found 1
Line 43:1: E302 expected 2 blank lines, found 1
Line 57:1: E302 expected 2 blank lines, found 1
Line 192:126: E501 line too long (126 > 125 characters)
Line 321:126: E501 line too long (142 > 125 characters)

Comment last updated at 2024-05-21 17:14:16 UTC

@mperrin mperrin requested a review from obi-wan76 May 22, 2024 18:02
Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as intended. I did the test for all the DHS apertures and I see that DHS1 and DHS6 have throughputs < 0.03

@obi-wan76 obi-wan76 merged commit 5d521c9 into spacetelescope:develop May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants