Roman docs & figures updates #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Skyhawk172, Thank you for updating ! There are no PEP8 issues in this Pull Request. Comment last updated at 2024-09-11 20:03:00 UTC |
obi-wan76
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the figures under the "Roman Instrument Model Details" section of the documentation as it appeared they had not been updated with the latest optical model (see GIF). The
how_tos.pywas also modified in order to rearrange the first figure.I also updated the caption to one of the figures to clearly state that the prism and grism PSFs shown are monochromatic.
Finally, I updated the Roman notebook, in particular by adding how to use the
datacube()function for the spectroscopic "filters".Note: there are no differences in the Roman CGI figures after re-running the code to generate the figure, so no update needed.
POST-FACTO EDIT: The root cause of the difference was tracked down to the fix for #666, which was rolled out as part of v1.2.0.