Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two tiny corrections found by mypy 1.13 #1032

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

dave42w
Copy link
Contributor

@dave42w dave42w commented Nov 16, 2024

Description

This PR fixes two problems found by the mypy typechecker.

processpool.py reuse of route_trype local var for two different actual types
ws.py was missing dict type self.methods: dict = {}

PR Checklist

Please ensure that:

  • [X ] The PR contains a descriptive title
  • [ X] The PR contains a descriptive summary of the changes
  • [ X] You build and test your changes before submitting a PR.
  • [ X] You have added relevant documentation
  • [ X] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 1:20am

Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #1032 will not alter performance

Comparing dave42w:my-py2 (b347d17) with main (5589ddf)

Summary

✅ 146 untouched benchmarks

@dave42w
Copy link
Contributor Author

dave42w commented Nov 16, 2024

Hi @sansyrox

Sorry about this. I don't see how this build timeout could be caused by my code.

@sansyrox
Copy link
Member

Hey @dave42w 👋

Don't worry about it :D

@dave42w
Copy link
Contributor Author

dave42w commented Nov 16, 2024

Hey @dave42w 👋

Don't worry about it :D

Is there anything I can/should do to trigger a re-check so this can be merged?

BTW did you see this warning from CI:

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

I guess it might be part of the cause of the failure

@sansyrox
Copy link
Member

@dave42w ,

That is coming from on of the dependencies. But we should update that for sure !

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :D

@sansyrox sansyrox merged commit 51bf8a3 into sparckles:main Nov 16, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants