Split out updateAttributes into a separate function.

sparhami · Sep 14, 2016 · 963f33f · 963f33f
1 parent 0fb2539
commit 963f33f
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 21 deletions.
diff --git a/perf/exploration.js b/perf/exploration.js
@@ -213,12 +213,16 @@
   };
 
   function elementOpen(tagName, key, statics) {
-    var node = coreElementOpen(tagName, key, elementCreated, statics);
+    coreElementOpen(tagName, key, elementCreated, statics);
+  }
+
+  function updateAttributes() {
+    var node = currentParent;
     var data = node['__incrementalDomData'];
 
     var attrsArr = data.attrsArr;
     var attrsChanged = false;
-    var i = 3;
+    var i = 0;
     var j = 0;
 
     for (; i < arguments.length && j < attrsArr.length; i += 1, j += 1) {
@@ -245,7 +249,7 @@
         newAttrs[attr] = undefined;
       }
 
-      for (i = 3; i < arguments.length; i += 2) {
+      for (i = 0; i < arguments.length; i += 2) {
         newAttrs[arguments[i]] = arguments[i + 1];
       }
 
@@ -286,6 +290,7 @@
     elementOpen: elementOpen,
     elementClose: elementClose,
     elementVoid: elementVoid,
-    text: text
+    text: text,
+    updateAttributes: updateAttributes
   };
 })(window);
diff --git a/perf/list/renderer.js b/perf/list/renderer.js
@@ -29,7 +29,8 @@ function ListRenderer(container, lib) {
       elementVoid = lib.elementVoid,
       elementOpen = lib.elementOpen,
       elementClose = lib.elementClose,
-      text = lib.text;
+      text = lib.text,
+      ua = lib.updateAttributes;
 
   function render(props) {
     var items = props.items;
@@ -41,29 +42,30 @@ function ListRenderer(container, lib) {
       var item = items[i];
       var isSelected = selectedKeys[item.key];
 
-      elementOpen('div', item.key, itemStatics,
-            'aria-selected', isSelected);
+      elementOpen('div', item.key, itemStatics);
+            ua('aria-selected', isSelected);
 
-        elementOpen('div', null, checkboxStatics,
-            'aria-checked', 'false');
+        elementOpen('div', null, checkboxStatics);
+            ua('aria-checked', 'false');
         elementClose('div');
 
-        elementOpen('div', null, starStatics,
-            'data-starred', item.starred,
-            'aria-label', item.starred ? 'Starred' : 'Not Starred');
+        elementOpen('div', null, starStatics);
+            ua('data-starred', item.starred,
+               'aria-label', item.starred ? 'Starred' : 'Not Starred');
         elementClose('div');
 
-        elementOpen('span', null, senderStatics,
-            'title', item.sender);
+        elementOpen('span', null, senderStatics);
+            ua('title', item.sender);
           text(item.sender);
         elementClose('span');
 
-        elementOpen('span', null, subjectStatics,
-            'title', item.subject);
+        elementOpen('span', null, subjectStatics);
+            ua('title', item.subject);
           text(item.subject);
         elementClose('span');
 
         elementOpen('span');
+            ua();
           text(item.date);
         elementClose('span');
 

diff --git a/perf/mutation/renderer.js b/perf/mutation/renderer.js
@@ -34,7 +34,8 @@ function MutationRenderer(container, lib) {
       elementVoid = lib.elementVoid,
       elementOpen = lib.elementOpen,
       elementClose = lib.elementClose,
-      text = lib.text;
+      text = lib.text,
+      ua = lib.updateAttributes;
 
   function render(props) {
     var items = props.items;
@@ -47,17 +48,20 @@ function MutationRenderer(container, lib) {
       var delta = item.value * item.change;
 
       elementOpen('tr', item.key, itemStatics);
+          ua();
         elementOpen('td', null, nameStatics);
-          elementOpen('a', null, null,
-              'href', item.name);
+            ua();
+          elementOpen('a');
+              ua('href', item.name);
             text(item.name);
           elementClose('a');
         elementClose('td');
         elementOpen('td', null, valueStatics);
+            ua();
           text(item.value, toFixedTwo);
         elementClose('td');
-        elementOpen('td', null, changeStatics,
-            'data-positive', item.change >= 0);
+        elementOpen('td', null, changeStatics);
+            ua('data-positive', item.change >= 0);
           text(delta, toFixedTwo);
           text(item.change, toPercent, toFixedTwo, wrapChange)
         elementClose('td');