Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Sparkle call LSRegisterURL? #508

Closed
zorgiepoo opened this issue Mar 30, 2015 · 3 comments
Closed

Should Sparkle call LSRegisterURL? #508

zorgiepoo opened this issue Mar 30, 2015 · 3 comments

Comments

@zorgiepoo
Copy link
Member

LSRegisterURL() registers or updates an application into Launch Service's database - should Sparkle use this after a plain or delta update of an application?

I found this bug, but perhaps it was not reported:
https://jira.atlassian.com/browse/SRCTREE-985

I see no reference to this function in Sparkle's source code. Note that this function can't be called from a sandboxed application (https://developer.apple.com/library/mac/documentation/Security/Conceptual/AppSandboxDesignGuide/AppSandboxDesignGuide.pdf).
@michelf
Copy link
Contributor

michelf commented Mar 30, 2015

Sparkle calls the mdimport command line tool here. I'd tend to believe that would register whatever is in the Info.plist file, but perhaps not.

@kornelski
Copy link
Member

That's interesting. I thought that launching a newly updated app would be enough. I think we can add it.

@grahammiln grahammiln mentioned this issue Apr 1, 2015
Merged
kornelski added a commit that referenced this issue Apr 1, 2015
@kornelski
Merge pull request #509 from grahammiln/launch-services
ddde282 
Register update with Launch Services; see #508
@grahammiln grahammiln mentioned this issue Apr 1, 2015
Merged
@kornelski
Copy link
Member

Fixed, thanks @grahammiln

@zorgiepoo zorgiepoo mentioned this issue Apr 18, 2015
Closed
kornelski added a commit that referenced this issue Apr 22, 2015
@kornelski
Revert "Register update with Launch Services; see #508"
ea07f71 
This reverts commit a7d11f8.

Fixes #525
zorgiepoo added a commit to zorgiepoo/Sparkle that referenced this issue Sep 27, 2015
@zorgiepoo
Update modification & access time for new update
6af2fbf 
If we don't do this, Finder may not report the correct file size for the new update.
The system also may not register the new app in its database if we don't do this.

We may have been able to get away with not doing this before because we used to perform a copy
to install the update. However, now updates in some cases can be done with only move operations.

This should also be an alternative way of addressing issue sparkle-project#508
@zorgiepoo zorgiepoo mentioned this issue Sep 27, 2015
Merged
@kornelski kornelski mentioned this issue Feb 15, 2016
Closed
@claui claui mentioned this issue Mar 27, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kornelski @michelf @zorgiepoo and others