fix: empty node set serialization when document encoding is nil

Fixes #2784 (backport)
sparklemotion · Feb 8, 2023 · f13cdb4 · f13cdb4
1 parent f6cecec
commit f13cdb4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/nokogiri/xml/node_set.rb b/lib/nokogiri/xml/node_set.rb
@@ -345,8 +345,9 @@ def to_html(*args)
           args.insert(0, options)
         end
         if empty?
-          encoding = (args.first.is_a?(Hash) ? args.first[:encoding] : nil) || document.encoding
-          "".encode(encoding)
+          encoding = (args.first.is_a?(Hash) ? args.first[:encoding] : nil)
+          encoding ||= document.encoding
+          encoding.nil? ? "" : "".encode(encoding)
         else
           map { |x| x.to_html(*args) }.join
         end

diff --git a/test/xml/test_node_set.rb b/test/xml/test_node_set.rb
@@ -961,6 +961,12 @@ def awesome!; end
             assert_equal(doc2, node_set[1].document)
           end
         end
+
+        describe "empty sets" do
+          it "#to_html returns an empty string" do
+            assert_equal("", NodeSet.new(xml, []).to_html)
+          end
+        end
       end
     end
   end