-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gem: attempt to build a darwin gem that works on multiple darwin versions #2082
Conversation
✅ Build nokogiri 1.0.674 completed (commit 75392a921f by @flavorjones) |
8bc0e5c
to
1c594b8
Compare
✅ Build nokogiri 1.0.678 completed (commit 3bfeb4a5d2 by @flavorjones) |
1c594b8
to
37122f7
Compare
37122f7
to
343e8e0
Compare
Code Climate has analyzed commit 343e8e0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.3% (0.0% change). View more on Code Climate. |
343e8e0
to
a7e93f1
Compare
@flavorjones Sorry for being so unresponsive in the last months! I was very busy at work. I plan to invest some time into rake-compiler-dock the next week and would like to add the MacOS cross compiler and a darwin target. Did you do anything with this cross compiler? Or everything native on MacOS? |
@larskanis I was also pretty busy with work and haven't had time to investigate using the cross-compiler. Was planning on queuing that work up for January if you hadn't gotten to it first. (I'm building the darwin images natively on my macbook for now.) |
related to #2079
See #2075 and #2079 for context. This branch attempts to generate a
x86_64-darwin
gem, following some of the patterns in thegrpc
gem but usingx86_64
instead ofuniversal
.