Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gem: attempt to build a darwin gem that works on multiple darwin versions #2082

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Sep 13, 2020

related to #2079

See #2075 and #2079 for context. This branch attempts to generate a x86_64-darwin gem, following some of the patterns in the grpc gem but using x86_64 instead of universal.

@flavorjones flavorjones marked this pull request as draft September 13, 2020 16:16
@AppVeyorBot
Copy link

@flavorjones flavorjones changed the title gem: attempt to build a universal-darwin gem gem: attempt to build a darwin gem that works on multiple darwin versions Sep 20, 2020
@flavorjones flavorjones force-pushed the 2079-flavorjones-universal-darwin-gems branch from 8bc0e5c to 1c594b8 Compare September 20, 2020 16:03
@AppVeyorBot
Copy link

@flavorjones flavorjones added this to the v1.11.0 milestone Dec 1, 2020
@flavorjones flavorjones added packaging/native-gem release-blocker Blocking a milestone release labels Dec 1, 2020
@flavorjones flavorjones force-pushed the 2079-flavorjones-universal-darwin-gems branch from 1c594b8 to 37122f7 Compare December 3, 2020 06:33
@flavorjones flavorjones force-pushed the 2079-flavorjones-universal-darwin-gems branch from 37122f7 to 343e8e0 Compare December 3, 2020 13:24
@codeclimate
Copy link

codeclimate bot commented Dec 3, 2020

Code Climate has analyzed commit 343e8e0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 94.3% (0.0% change).

View more on Code Climate.

@flavorjones flavorjones force-pushed the 2079-flavorjones-universal-darwin-gems branch from 343e8e0 to a7e93f1 Compare December 3, 2020 17:33
@flavorjones flavorjones marked this pull request as ready for review December 3, 2020 17:33
@flavorjones flavorjones merged commit 609297d into master Dec 3, 2020
@flavorjones flavorjones deleted the 2079-flavorjones-universal-darwin-gems branch December 3, 2020 18:06
@larskanis
Copy link
Member

@flavorjones Sorry for being so unresponsive in the last months! I was very busy at work. I plan to invest some time into rake-compiler-dock the next week and would like to add the MacOS cross compiler and a darwin target. Did you do anything with this cross compiler? Or everything native on MacOS?

@flavorjones
Copy link
Member Author

@larskanis I was also pretty busy with work and haven't had time to investigate using the cross-compiler. Was planning on queuing that work up for January if you hadn't gotten to it first. (I'm building the darwin images natively on my macbook for now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging/native-gem release-blocker Blocking a milestone release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants