Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method is_new_part returns wrong part PK when checking if there is a new manufacturer part #94

Closed
orlandod543 opened this issue Jul 26, 2022 · 1 comment · Fixed by #98

Comments

@orlandod543
Copy link

  • The method iterates through all the part in the list of parts

  • inside the loop, when no match is found between parameters or between name and description, the method checks if there is a new manufacturer part.
    image

  • In the case that the MPN already exist in the database, compare is set to true and the loop breaks, returning the pk of the first element in the part_list.
    image

Expected behavior:

  • The method should return the pk of the part with the matching manufacturing part number
@eeintech
Copy link
Contributor

Hello @orlandod543, thanks for reporting this issue. I will take a look as soon as I can 👍

eeintech added a commit that referenced this issue Aug 5, 2022
This was referenced Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants