Use nbconvert's preprocessor framework #650
Conversation
|
Hello @jasongrout! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-06-22 04:30:43 UTC |
This enables users to give nbconvert configuration, such as preprocessor settings, as part of their sphinx config.
This allows the cell removal plugins to remove cells before execution, for example. There is a problem using this nbsphinx with ipywidets - it complains about missing files in the html-collect-pages step.
jasongrout
force-pushed
the
preprocessors
branch
from
ae75fd1
to
369a2c0
Compare
This uses the first commit of spatialaudio/nbsphinx#650, f963a2a3b7f31a844b31a3fca0fe653f37b500a2, in order to pass nbconvert options to nbsphinx.
|
Thanks for this PR and sorry for my late response! It would be great if we could provide a hook for users to provide additional preprocessor settings. Sadly, I don't have time to look into this either, but maybe someone else does? I was wondering if the However, I think we should force |
As noted in #341 (comment), nbsphinx directly uses the nbconvert execute preprocessor before the preprocessor queue is invoked. This changes the logic to use the nbconvert preprocessor queue. It also enables the user to give a configuration for preprocessors (for example, I used this to remove cells with certain tags).
The first commit in this PR appears to work just fine. However, with the second commit applied, building the ipywidgets docs with nbsphinx ends with some errors about files (notebooks) not found in the html-collect-pages step. Unfortunately, I ran out of time to debug this, but am opening a draft PR with my current in-progress work in hopes it will be of use.
This begins to address comments from #285, #305, #341.