-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vietnamese holidays #115
Add vietnamese holidays #115
Conversation
…am is calculated correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, thanks! The Trait is usable for other Countries (like Malaysia) too, I assume?
@Nielsvanpach Thanks! And yes, that can be used by any other Asian countries that also use Chinese Calendars. |
Thanks! |
Holidays in Vietnam According to Wikipedia:
I copied and refactored the
chineseCalendar
method from PR #51 to convert dates from Chinese Calendar to Gregorian one. That becomes theChineseCalendar
trait. We might need that trait for the following countries: