Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add calendar for Nepal #247

Merged
merged 5 commits into from
Oct 19, 2024
Merged

feat: add calendar for Nepal #247

merged 5 commits into from
Oct 19, 2024

Conversation

maskeynihal
Copy link
Contributor

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?

Add for Nepal.

@maskeynihal
Copy link
Contributor Author

Need help with data collection for holiday.

@Nielsvanpach
Copy link
Member

Thanks! Could you solve the phpstan issues?

@maskeynihal
Copy link
Contributor Author

Thanks! Could you solve the phpstan issues?

Just did. Can you please check it? Thanks 🙏

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 608ed0d into spatie:main Oct 19, 2024
14 checks passed
@maskeynihal
Copy link
Contributor Author

@Nielsvanpach Could you please add the "hacktoberfest-accepted" label to my PR? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maskeynihal @Nielsvanpach