Add Support for Laravel 11 #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanzweifel
commented
Feb 6, 2024
| @@ -17,7 +17,7 @@ | |||
| it('can determine the age in days', function () { | |||
| Carbon::setTestNow(Carbon::create(2016, 1, 1)->startOfDay()); | |||
|
|
|||
| expect(Format::ageInDays(Carbon::now()))->toEqual('0.00 (1 second ago)'); | |||
| expect(Format::ageInDays(Carbon::now()->subSeconds(5)))->toEqual('0.00 (5 seconds ago)'); | |||
There was a problem hiding this comment.
Updated the assertion here to be compatible with Carbon v2 and v3.
Internally v3 uses floats instead of integers.
This led to issues when the diff was ~0 seconds. See test run.
There's also a great summary of the major changes in this comment: laravel/framework#49764 (comment)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependency constraints to support Laravel 11 and GitHub Actions workflow to run the test suite for Laravel 11 as well.
Test suite currently fails for Laravel 11 installations that either use Carbon v2 or Carbon v3. (diffForHumans()transforms 0 seconds either to "1 second ago" or "0 seconds ago".)Edit: Fixed the test suite by updating the assertions.