Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V6] Full uuid/guid/ulid support #2089

Merged
merged 2 commits into from
Feb 10, 2023
Merged

[V6] Full uuid/guid/ulid support #2089

merged 2 commits into from
Feb 10, 2023

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented May 6, 2022

  • UUID/GUID/ULID full support on all methods
  • Custom UUID Models on tests

keeps the same operation as always


#1909 (comment)

I see a new migration in there,

Migration removed, and now use the actual migration with a replace string as temporary migration

Could you please break this PR up in smaller ones that are easier to review?

This is the smaller piece of code


Closes #1623
Closes #1584
Closes #1567
Closes #1561
Closes #1537
Closes #1477
Closes #1420
Closes #1366
Closee #1260
Closes #948
Closes #2043
Closes #1854
Closes #2083
Closes #1434
Closes #489
Closes #793
Closes #2329
Closes #2373


UPDATE: Rebased and ULIDs support added

Simfony/Component/Uid/Uuid::isValid()
Simfony/Component/Uid/Ulid::isValid()


Maybe change data type on findById is a breaking change for somebody overwriting that function,
if that is true, maybe for V6 release

@erikn69 erikn69 closed this May 6, 2022
@erikn69 erikn69 changed the title [V5] Full uuid support [V6] Full uuid support Feb 6, 2023
@erikn69 erikn69 changed the title [V6] Full uuid support [V6] Full uuid/ulid support Feb 6, 2023
@erikn69 erikn69 reopened this Feb 6, 2023
@erikn69 erikn69 force-pushed the fix_2022 branch 2 times, most recently from 9394883 to a8149f4 Compare February 6, 2023 18:00
@erikn69 erikn69 changed the title [V6] Full uuid/ulid support [V6] Full uuid support Feb 6, 2023
@erikn69 erikn69 closed this Feb 6, 2023
@erikn69 erikn69 changed the title [V6] Full uuid support [V6] Full uuid/guid/ulid support Feb 9, 2023
@drbyte
Copy link
Collaborator

drbyte commented Feb 10, 2023

Thanks!

@drbyte
Copy link
Collaborator

drbyte commented Feb 10, 2023

Merging to v6/dev-master

@drbyte drbyte merged commit 3115a43 into spatie:main Feb 10, 2023
@erikn69 erikn69 deleted the fix_2022 branch February 17, 2023 14:40
@erikn69 erikn69 mentioned this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment