Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Minor point: rogue console.log #10

Closed
mdcass opened this issue Aug 1, 2024 · 2 comments
Closed

[Bug]: Minor point: rogue console.log #10

mdcass opened this issue Aug 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mdcass
Copy link

mdcass commented Aug 1, 2024

What happened?

Rogue console.log at /resources/views/upload.blade.php#L67.

How to reproduce the bug

If you publish assets

php artisan vendor:publish --tag="livewire-filepond-views"

You will see the console.log in the resulting file on line 67.

Package Version

1.1

PHP Version

8.2

Laravel Version

11.9

Which operating systems does with happen with?

macOS

Notes

Unrelated to this bug (and I will raise another bug soon when I rule out it's just me being stupid) I found this console.log after publishing the view as I wanted to debug why my Filepond attributes aren't going through to the actual component:

<x-filepond::upload
    wire:model="file"
    max-files="5"
    multiple="true"
    credits="false"
    placeholder="Why am I not seeing this?"
/>

But we're not seeing what i'd expect (no placeholder set, it's still single file upload):
image

@mdcass mdcass added the bug Something isn't working label Aug 1, 2024
@RoccoHoward
Copy link
Contributor

RoccoHoward commented Aug 2, 2024

The localization change in #8 is causing this.

placeholder is set in labelIdle: @js($placeholder), (line 72)
labelIdle is also in the localization files which is then set in pond.setOptions(@js($pondProperties)); line 79

I've pushed a fix by moving this option being set after localization

pond.setOptions({ labelIdle: @js($placeholder) });

@l0gical
Copy link

l0gical commented Aug 2, 2024

Would that be the similar reason why credits="false" as per the OP has no effect on their attached image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants