Fixes Tool Page Title #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Spatie team, please let me know if there's any feedback to get this merged, happy to make changes is needed! |
|
Could you resolve the conflicts? |
|
Sure thing, must be due to the other PR that was just merged -- will get sorted asap! |
aryehraber
force-pushed
the
fix/page-title
branch
from
a15fb26
to
dfee728
Compare
|
Alright, rebased from master and rebuilt the assets -- should be good to go now! (not sure why the tests are failing, don't think this has to do with the PR) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems PR #108 tried adding a Page Title to the Backup Tool, however it doesn't work due to a missing reference to the
__()method.This is the error I'm seeing in Nova when visiting the Backup Tool:
Since the
__()is bound to the Vue instance, it needs to bethis.__(). Let me know if there are any questions, thanks!