Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added help-text component to form field #138

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Conversation

aliozgurr
Copy link
Contributor

@aliozgurr aliozgurr commented Jan 24, 2022

I had the possibility to add help text to Tags field by using ->help('Text'), but it was invisible on the forms.

So I've added the help-text tag to FormField component and my problem was solved.

The field on forms after the change:
Ekran Resmi 2022-01-24 17 46 14

P.S: This is my first time opening a PR in a public repository, so if I missed something please let me know and I'll fix it.

@freekmurze freekmurze merged commit d36a585 into spatie:main Jan 25, 2022
@freekmurze
Copy link
Member

Thanks!

@aliozgurr
Copy link
Contributor Author

Hey @freekmurze, I forgot to include the compiled dist/field.js in this PR, so my code exists but the change doesn't apply for now because this PR doesn't include newly compiled dist/field.js.

Can you please tell me what to do? Should I open a new PR after running npm run dev locally, or is there something you can do?

Sorry about the situation, this is my first time contributing 🙂

@freekmurze
Copy link
Member

Hi @aliozgurr

You'll have to run yarn run production or npm production and commit the updated .js file.

Could you run that command and PR the changes?

@aliozgurr
Copy link
Contributor Author

Hey @freekmurze,

Just did what you told me on #139.

@LintonAchmad
Copy link
Contributor

mmm so I can't find the actual help-text component - maybe this should be span or p tag?

@LintonAchmad
Copy link
Contributor

also help tag works fine on forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants