Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShouldNotHappenException No original request where 404 should be returned #158

Closed
spaze opened this issue Jul 1, 2023 · 1 comment · Fixed by #160 or #162
Closed

ShouldNotHappenException No original request where 404 should be returned #158

spaze opened this issue Jul 1, 2023 · 1 comment · Fixed by #160 or #162
Assignees

Comments

@spaze
Copy link
Owner

spaze commented Jul 1, 2023

After #155, MichalSpacekCz\ShouldNotHappenException: No original request is thrown in

throw new ShouldNotHappenException('No original request');

When visiting URLs like https://www.michalspacek.cz/.env

This is because previously a different exception was thrown and catch'd:

throw new InvalidLinkException('No request');

@spaze
Copy link
Owner Author

spaze commented Jul 1, 2023

After #160 has been merged, Nette\Application\UI\InvalidLinkException: No route for Admin:Homepage:default() is thrown in

$links[$locale] = $linkGenerator->link($destination, $this->getParams($params, $locale));

when visiting Admin, Pulse and other modules that are not translated.

@spaze spaze reopened this Jul 1, 2023
spaze added a commit that referenced this issue Jul 1, 2023
spaze added a commit that referenced this issue Jul 1, 2023
@spaze spaze closed this as completed in #162 Jul 1, 2023
spaze added a commit that referenced this issue Jul 1, 2023
Close #158 (again)

This pull request replaces #160 which has been reverted here as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant