-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for disallowing namespaces #51
Conversation
547abe9
to
2b6de35
Compare
You could think: Why not just use That would work, but only for method calls. In my case I wanted to prevent the use of class MyClass
{
private $requestStack;
public function __construct(RequestStack $requestStack)
{
$this->requestStack = $requestStack;
}
public function doSomething()
{
// Pass the object to something else.... we didn't call anything
$model = Model::createFromRequestStack($this->requestStack);
}
} |
Thanks. I'm fine with a new config key. Can you please squash the commits or somehow fix the commits so I can review? The "Add tests" commit now changes other areas too, guess it shouldn't. |
I'm not with my computer anymore. Please review from GH diff view. Before we merge it I'll squash it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick round 1 of review.
Please also squash the commits to remove unrelated changes, thanks.
9ecf883
to
058dd4e
Compare
Updated the PR. Much better now. |
058dd4e
to
10c1f1e
Compare
10c1f1e
to
8e5f5fc
Compare
Thank you, much better, agree 👍 Made minor changes (some whitespace removal, added namespaces to the docs, removed one |
Just released this in 1.3.0, thank you for your contribution. |
Thanks for merging all the PR's and the kind words in the release notes 💙 |
See #50
Currently it only triggers on
FullyQualified
nodes.