Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404: Add conformance.md and changes-from-previous-iso.md to the website build #1057

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 12, 2024

  • Fix 404 of "Conformance" chapter
  • Fix 404 of "Changes from the previous standard" chapter
    • Corrected the file name to changes-from-previous-iso.md

Also raise the validation level of not_found to warn, so the next time an issue like this will be detected during PR submission.

conformance.md was in nav, but also in draft_docs, made it not available in build and thus 404.

Fixed by removed it from draft_docs

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested review from zvr and goneall August 12, 2024 00:21
Update diffs-from-previous-iso.md to changes-from-previous-iso.md

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Aug 12, 2024

There's one warning in validation, from the missing omg-history.md

WARNING - A reference to 'omg-history.md' is included in the 'nav' configuration, which is not found in the documentation files.

PR #1053 has be applied before this PR

@bact bact changed the title Add conformance.md to the website build Fix 404: Add conformance.md and changes-from-previous-iso.md to the website build Aug 12, 2024
@kestewart kestewart added this to the 3.0.1 milestone Aug 12, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall merged commit b2f7464 into spdx:development/v3.0.1 Aug 12, 2024
2 checks passed
@bact bact deleted the enable-conformance-in-nav branch August 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants