Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address case sensitivity for license expressions #222

Closed

Conversation

swinslow
Copy link
Member

This commit attempts to reflect the outcome of the discussion at
#63 regarding whether
license expression operators and identifiers should be matched in
a case-sensitive manner.

Specifically it attempts to reflect the comment at
#63 (comment)
regarding the outcome of the tech team discussion on 2018-06-05.

Closes #63

@goneall -- would greatly appreciate your review, as I'm not certain whether I'm accurately capturing the intent of the comment linked above. Thanks!

Signed-off-by: Steve Winslow [email protected]

This commit attempts to reflect the outcome of the discussion at
spdx#63 regarding whether
license expression operators and identifiers should be matched in
a case-sensitive manner.

Specifically it attempts to reflect the comment at
spdx#63 (comment)
regarding the outcome of the tech team discussion on 2018-06-05.

Signed-off-by: Steve Winslow <[email protected]>
@swinslow swinslow requested a review from goneall March 24, 2020 15:26
@swinslow swinslow added this to the 2.2 milestone Mar 24, 2020
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches my understanding of the discussions and agreement from the meeting.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing license ID's to be case sensitive.

chapters/appendix-IV-SPDX-license-expressions.md Outdated Show resolved Hide resolved
@kestewart
Copy link
Contributor

Flagging that tool providers may need to consider this, spdx tools has this implemented at this point.

@kestewart
Copy link
Contributor

Thomas asked about license exception identifiers, Steve added clarity based.
Alexios suggested just saying canonical identifier, to remove ambiguities as well.

@swinslow
Copy link
Member Author

swinslow commented Apr 7, 2020

closed in favor of #228 due to merge conflicts here

@swinslow swinslow closed this Apr 7, 2020
@swinslow swinslow deleted the expr-case-sensitivity branch April 7, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify case sensitivity of Short Form licenses - for list and tools.
3 participants