[issue-381] Add tag-value writer #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
armintaenzertng
changed the title
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
We do not want to take invalid files into account when writing. For such cases, validation should be performed before the writing process. Signed-off-by: Armin Tänzer <[email protected]>
also rename write_package_verification_code, erase a line in the test example and an erroneous break Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
armintaenzertng
force-pushed
the
addTagValueWriter
branch
2 times, most recently
from
e7d0f68
to
e0d0dbd
Compare
Signed-off-by: Armin Tänzer <[email protected]>
armintaenzertng
force-pushed
the
addTagValueWriter
branch
from
e0d0dbd
to
96f62bd
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes over from #395.
Fixes #381.
This PR includes code from #379, so depending on which PR is merged first, there will probably be merge conflicts with the one or the other when rebasing.