[issue-386] Finish Package validation #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
meretp
approved these changes
Feb 1, 2023
Comment on lines
+29
to
+31
| (PackageVerificationCode("71c4025dd9897b364f3ebbb42c484ff43d00791c", ["/invalid/excluded/file"]), | ||
| 'file name must not be an absolute path starting with "/", but is: /invalid/excluded/file') | ||
| ]) |
There was a problem hiding this comment.
You could add one more testcase with an uppercase checksum as you added this in the vlaidation message.
There was a problem hiding this comment.
ah yes, and I wanted to give checksums the same treatment
| validation_messages.append( | ||
| ValidationMessage( | ||
| f"package must contain no elements if files_analyzed is False, but found {contained_in_package_relationships}", | ||
| f"package must contain no elements if files_analyzed is False, but found {combined_relationships}", |
There was a problem hiding this comment.
Reading this, I was wondering if a package must contain no elements in general or only files? The spec is mostly referring to files and I am not sure, if a package could contain anything other than a file.
There was a problem hiding this comment.
I don't think it can contain anything else than files. This is not explicitly stated by the spec for relationships, so who knows... I would leave it like that for now.
Signed-off-by: Armin Tänzer <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #386