[issue-394] add tests for tag_value writer #567
Conversation
There was a problem hiding this comment.
Thanks for the effort, much appreciated! :)
However, I think it would be in our best interest to replace all of the value strings with references to the fixture values, at least where possible.
For example, "FileName: ./fileName.py\n" would become f"FileName: {file_fixture().name}\n"
|
You are absolutely right, I replaced most strings. I didn't replace date strings and other strings that have a bit more logic than just a reference to the fixture value, please have another look. |
|
|
||
| mock.assert_called_once_with("foo", "w") | ||
| handle = mock() | ||
| handle.write.assert_has_calls( |
There was a problem hiding this comment.
This method allows other calls before or after the given list of calls. I haven't found a way to check that there are no such calls but maybe this isn't too important to check right now, anyway.
There was a problem hiding this comment.
Yes, another option would be assert_has_calls but this wouldn't check the order of calls, which is more important I think than the "risk" of calls before or after this statement.
Signed-off-by: Meret Behrens <[email protected]>
meretp
force-pushed
the
issue_394_add_tests_for_tag_value_writer
branch
from
3cf8389
to
a662853
Compare
fixes #394