Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make example files valid #607

Merged
merged 1 commit into from
Apr 24, 2023
Merged

make example files valid #607

merged 1 commit into from
Apr 24, 2023

Conversation

meretp
Copy link
Collaborator

@meretp meretp commented Apr 24, 2023

I noticed that these two example files are marked as invalid. The changed files align with the examples given in the spdx-spec repo. As far as I understand the spec we only add the documents namespace to referenceType in RDF format, not in any other. So I think the examples were simply incorrect and there is no need to adapt the code to accept these kind of referenceType.

Signed-off-by: Meret Behrens <[email protected]>
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly does not make sense to define "purl" in the local namespace.

We should also open a PR against the spec.

@meretp meretp merged commit fdb9084 into spdx:main Apr 24, 2023
@meretp meretp deleted the fix-example-files branch April 24, 2023 07:07
@meretp
Copy link
Collaborator Author

meretp commented Apr 24, 2023

We should also open a PR against the spec.

No need to open a PR against the spec, the files in the spec don't have a namespace at the fields. Sorry, if I wasn't clear on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants