Fix support for node LTS versions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add package lock chore: remove old node code test: fix tests
2 tasks
Volune
added a commit
to Volune/webpack-dev-server
that referenced
this pull request
Mar 12, 2019
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.writevto comply with node 10 supportChanges in node 11.1.0
The build is currently breaking for node 11.1.0 as the params for
onStreamReadhave changed https://github.com/nodejs/node/blob/v11.1.0/lib/internal/stream_base_commons.js#L111. This module will need to be updated to support that change. I am leaving that as a separate item for now since this PR is aimed to fix support for LTS versions of node.