Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type hints nullable parameters #1972

Merged

Conversation

druizz90
Copy link
Contributor

@druizz90 druizz90 commented Sep 4, 2024

Improve type hints for arguments that are nullables and fix flake8 pre-commit hook.

Changes proposed in this pull request:

  • Update pre-commit configuration with the latest version of flake8 to prevent errors
  • Improve type hints for parameters that are nullables

@coveralls
Copy link

Coverage Status

coverage: 94.15% (+0.003%) from 94.147%
when pulling b2de340 on druizz90:improve-type-hints-nullable-strings
into be9b280 on spec-first:main.

@RobbeSneyders
Copy link
Member

Thanks @druizz90!

@RobbeSneyders RobbeSneyders merged commit 17f5ed0 into spec-first:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants