-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser for GDOL, first attempt #1911
base: master
Are you sure you want to change the base?
Conversation
Adding "pattern" to |
With
I get only one parameter:
This surprises me a bit, I thought ";" as a terminating would make me have 3 parameters. We can get 3 parameters using the notation of the paper |
I think the reason is that the basic spec parser uses other terminating keywords than the structured spec and library parsers. |
…ations in pattern bodies
Not intended for merging, ignore any style issue or use of tracing messages.
Issues:
gives a parse error because the list is not the last element in the list of parameters. Moving the optional argument before it makes the example go through. The fact that the parameter following the list is optional has no relevance (removing the ? still gives an error).
I would have the same problem in instantiations
P[A; X::Xs; B]
so I have not implemented this yet.goes through, but removing the optional end after the local patterns makes the parser fail (
skip
as a separator most likely not the best idea). At the level oflibItem
s, that also have an optional end, these are parsed with a recursive function that also tries to parse annotation. Should follow the same approach here?How should I parse the missing optional parameter?
Using
hetIRI
to parsegreater[C]
does not work. I have usedcompoundIriCurie
. But I wonder ifhetIRI
does what it should.