Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting a user as admin does not set their 6 collections #2695

Closed
grantfitzsimmons opened this issue Dec 20, 2022 · 4 comments · Fixed by #3755 or #4652
Closed

Setting a user as admin does not set their 6 collections #2695

grantfitzsimmons opened this issue Dec 20, 2022 · 4 comments · Fixed by #3755 or #4652
Assignees
@acwhite211 @CarolineDenis
Labels
1 - Bug Incorrect behavior of the product 2 - Security & Accounts Issues that are related to the permission system and user accounts
Milestone
7.9.6

Comments

@grantfitzsimmons
Copy link
Member

image

Found this today when I set zrogers to admin in Specify 6. I was still encountering the "no collections" warning in 6 until I unset admin, selected the collection, then selected the collections.

This is all on a local install of 6, 7, and MariaDB on macOS.
@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product pri:unknown labels Dec 20, 2022
@grantfitzsimmons
Copy link
Member Author

Still a major nuisance, and potentially the cause of CSIRO's issue on Asana.

@grantfitzsimmons
Copy link
Member Author

A user ran into this issue today again. Something we should consider resolving sooner than later.

@CarolineDenis CarolineDenis added this to the 7.9.1 milestone Jul 10, 2023
CarolineDenis added a commit that referenced this issue Jul 10, 2023
@CarolineDenis
Enable 'set collections' button when user is set as admin
b5bcb4f 
Fixes #2695
@CarolineDenis CarolineDenis mentioned this issue Jul 10, 2023
Merged
@grantfitzsimmons grantfitzsimmons linked a pull request Jul 14, 2023 that will close this issue
Enable 'set collections' button when user is set as admin #3755
Merged
@grantfitzsimmons grantfitzsimmons added the 2 - Security & Accounts Issues that are related to the permission system and user accounts label Jul 14, 2023
@grantfitzsimmons
Copy link
Member Author

Screen.Recording.2024-03-06.at.1.20.18.PM.mov

https://umherb11024-edge.test.specifysystems.org/specify/security/user/156/?collection=4

I created the user csiro on the database umherb_1_10_24. When I set the user as an admin, I was surprised to see the collections were not set, indicating this was likely reverted during the merge.

Specify 7 System Information - 2024-03-06T19_17_40.911Z.txt

@grantfitzsimmons grantfitzsimmons modified the milestones: 7.9.1, 7.9.4 Mar 6, 2024
@grantfitzsimmons
Copy link
Member Author

Seems that it was broken already in v7.9.3
image
I set the admin role for this user, but the collection access was still not granted

@CarolineDenis CarolineDenis modified the milestones: 7.9.4, 7.9.5, 7.9.6 Mar 6, 2024
CarolineDenis added a commit that referenced this issue Mar 14, 2024
@CarolineDenis
Check all 6 collections when select set as admin for 6
268443a 
Fixes #2695
@CarolineDenis CarolineDenis mentioned this issue Mar 14, 2024
Merged
2 tasks
@CarolineDenis CarolineDenis self-assigned this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acwhite211 acwhite211

@CarolineDenis CarolineDenis

Labels
1 - Bug Incorrect behavior of the product 2 - Security & Accounts Issues that are related to the permission system and user accounts
Projects
Back-End Backlog
Status: ✅ Done
Users & Permissions
Status: Shipped
Milestone
7.9.6
5 participants
@acwhite211 @grantfitzsimmons @maxpatiiuk @chanulee1 @CarolineDenis