Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird positioning of buttons on narrow screens #3681

Closed
maxpatiiuk opened this issue Jun 25, 2023 · 8 comments · Fixed by #3713
Closed

Weird positioning of buttons on narrow screens #3681

maxpatiiuk opened this issue Jun 25, 2023 · 8 comments · Fixed by #3713
Assignees
@CarolineDenis
Labels
1 - Bug Incorrect behavior of the product 2 - User Interface Issues that are related to the user interface or user experience.

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Jun 25, 2023 •
edited
Loading

The query builder toolbar buttons are arranged into a "holy trinity" on narrower screens

Screenshot 2023-06-24 at 19 24 47

Happend on the xml-editor branch
@maxpatiiuk maxpatiiuk added the 1 - Bug Incorrect behavior of the product label Jun 25, 2023
@CarolineDenis
Copy link
Contributor

Is in production too
Screenshot 2023-06-30 at 12 56 45 PM

@CarolineDenis
Copy link
Contributor

I changed it to be like that as I thought it looked weird the way it was before:
Screenshot 2023-06-30 at 1 05 39 PM

@CarolineDenis
Copy link
Contributor

could be justify end:
Screenshot 2023-06-30 at 1 06 48 PM

@CarolineDenis
Copy link
Contributor

CarolineDenis commented Jun 30, 2023 •
edited
Loading

NOTES:
This happens only in a rare case, 2mm over or 2mm under and we're good
Screenshot 2023-06-30 at 1 11 01 PM

@maxpatiiuk
Copy link
Member Author

ok, then maybe not big deal

though I am still not a fun of centering headers - don't think that looks good, but I will defer to others for this

@grantfitzsimmons grantfitzsimmons added the 2 - Queries Issues that are related to the query builder or queries in general label Jul 2, 2023
@CarolineDenis
Copy link
Contributor

CarolineDenis commented Jul 3, 2023 •
edited
Loading

@grantfitzsimmons @melton-jason, do you prefer center, left or right? I personally don't have a strong opinion on this. I'll go with the majority.

@grantfitzsimmons
Copy link
Member

I vote right-aligned!
I am also not a fan of centering headers.

CarolineDenis added a commit that referenced this issue Jul 3, 2023
@CarolineDenis
Right align header buttons in query builder
179e28d 
Fixes #3681
@CarolineDenis CarolineDenis mentioned this issue Jul 3, 2023
Merged
@melton-jason
Copy link
Contributor

melton-jason commented Jul 3, 2023 •
edited
Loading

Right align might make more sense to make better use of the space! The left side is probably going to usually be the busiest side!

@grantfitzsimmons grantfitzsimmons added 2 - User Interface Issues that are related to the user interface or user experience. and removed 2 - Queries Issues that are related to the query builder or queries in general labels Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarolineDenis CarolineDenis

Labels
1 - Bug Incorrect behavior of the product 2 - User Interface Issues that are related to the user interface or user experience.
Projects
Front-End Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Right align header buttons in query builder specify/specify7
4 participants
@grantfitzsimmons @maxpatiiuk @melton-jason @CarolineDenis