404 in background when notifications are open with a deleted agent referenced

[bronwyncombs]

Describe the bug
After merging an agent and opening the notifications dialog from the navigation menu, the query page in the background changes to 404.

To Reproduce
Steps to reproduce the behavior:

1. Merge agent
2. Click on Notifications
3. See error

Expected behavior
Should remain on query builder page

Screenshots

Screen.Recording.2023-08-02.at.9.19.38.AM.mov

Desktop:

• macOS, chrome, v7.9

Database Name: herb_rbge_3_31_23

[bronwyncombs]

To clarify, this issue occurs whenever notifications are opened while a merge is in process - not just directly after a merge is initiated or only from the query page

Screen.Recording.2023-08-02.at.12.13.03.PM.mov

[CarolineDenis]

@bronwyncombs, can you reproduce with the last version of v7.9-dev? Can you reproduce with other db?

[bronwyncombs]

@CarolineDenis, working as expected in umichmollusks! I don't know what's causing it this in herb_rbge.

[CarolineDenis]

Maybe same cause than: #3892

[grantfitzsimmons]

The current theory is that a deleted agent cannot be returned, so it results in a 404 when the linked agent record formatted preview attempts to load.

[grantfitzsimmons]

From @carlosmbe in #3896:

Describe the bug
Uploaded some agents via Work Bench. There were some duplicates in this spread sheet. Merged them. Then rolled back. Now I get a 404 throughout Specify if I open notifications.

Beautiful Screen Recording

This starts from rolling back the agents

Screen.Recording.2023-08-03.at.10.58.30.AM.mp4

Desktop:

• OS: Mac OS
• Browser: Chrome
• Specify 7 Version: 7.9

[grantfitzsimmons]

@bronwyncombs believes this is something that must be fixed before release

[CarolineDenis]

NOTES:
Issue + steps to reproduce

• merge 2 agents
• keep in the notification component the 'has started' and the 'has succeeded'
• merge the newly created agent with another one
• open the notifications.
  See=>
• first 'succeeded' notification has now a pending link
• in the console we have an error "No Agent matches the given query"
• Pop up toast error because error when fetching agent

Conclusion, we are trying to fetch an agent that doesn't exist anymore to create the link.
(Just for the test, if we delete the notification with stale/invalid link the error disappear)
==> Line 37 in FormattedResource.tsx
the use of useFormatted

[CarolineDenis]

Decision made by the group:
Change the FormattedResource link to a NewTab link.

[melton-jason]

Fixed in #3906