Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve schema viewer user experience #2816

Merged
merged 11 commits into from
Jan 20, 2023
Merged

Improve schema viewer user experience #2816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
14ac8e4
Change schema viewer layout to single page
CarolineDenis Jan 12, 2023
0966998
Add a sidebar on db model page
CarolineDenis Jan 13, 2023
233b19f
Hide side bar menu on small screens
CarolineDenis Jan 13, 2023
d71eb92
Simplify user prefs page naming
maxpatiiuk Jan 13, 2023
3878312
Merge remote-tracking branch 'origin/production' into issue-1831
maxpatiiuk Jan 16, 2023
a00a8b7
Rewrite useActiveCategory hook
maxpatiiuk Jan 16, 2023
7029891
Rename useActiveCategory hook
maxpatiiuk Jan 16, 2023
6429bea
Rename Schema page to DataModel
maxpatiiuk Jan 16, 2023
18648e2
Add a Go To Top link to Data Model viewer
maxpatiiuk Jan 16, 2023
e4ee989
Fixes #2815
grantfitzsimmons Jan 16, 2023
6d3c588
Make DataModel viewer typing safer
maxpatiiuk Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions specifyweb/frontend/js_src/lib/components/AppResources/TabDefinitions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import { writable } from '../../utils/types';
import { useCodeMirrorExtensions } from './EditorComponents';
import { PreferencesContext, useDarkMode } from '../UserPreferences/Hooks';
import { PreferencesContent } from '../UserPreferences';
import { useId } from '../../hooks/useId';
import { useLiveState } from '../../hooks/useLiveState';
import { appResourceSubTypes } from './types';
import { SerializedResource } from '../DataModel/helperTypes';
Expand Down Expand Up @@ -93,7 +92,6 @@ const UserPreferencesEditor: AppResourceTab = function ({
data,
onChange: handleChange,
}): JSX.Element {
const id = useId('user-preferences');
const [preferencesContext] = useLiveState<
React.ContextType<typeof PreferencesContext>
>(
Expand Down Expand Up @@ -124,7 +122,7 @@ const UserPreferencesEditor: AppResourceTab = function ({

return (
<PreferencesContext.Provider value={preferencesContext}>
<PreferencesContent id={id} isReadOnly={isReadOnly} />
<PreferencesContent isReadOnly={isReadOnly} />
</PreferencesContext.Provider>
);
};
Expand Down
6 changes: 3 additions & 3 deletions specifyweb/frontend/js_src/lib/components/Router/Routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ export const routes: RA<EnhancedRoute> = [
index: true,
title: schemaText.databaseSchema(),
element: () =>
import('../Toolbar/Schema').then(
import('../Toolbar/DataModel').then(
({ DataModelTables }) => DataModelTables
),
},
{
path: ':tableName',
element: () =>
import('../Toolbar/Schema').then(
({ DataModelTable }) => DataModelTable
import('../Toolbar/DataModel').then(
({ DataModelRedirect }) => DataModelRedirect
),
},
],
Expand Down
Loading