Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional instructions for django migrations #3628

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

grantfitzsimmons
Copy link
Member

Fixes #3626

Is this explanation satisfactory?

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Small clarification: It's not that root is required, but that user with more permissions is required (my master user has all permissions, so I had no issues with this - of course that is not suitable for production). Worth clarifying or not worth the complexity?
  2. When you modify docker compose, I believe you have to rebuild for changes to env variables to take effect - not sure. Could you try changing the MASTER_NAME and see if changes apply after restarting without rebuild?

@grantfitzsimmons
Copy link
Member Author

  • Small clarification: It's not that root is required, but that user with more permissions is required (my master user has all permissions, so I had no issues with this - of course that is not suitable for production). Worth clarifying or not worth the complexity?

I understood this before writing, but I was worried it would add too much complexity to explain this.

When you modify docker compose, I believe you have to rebuild for changes to env variables to take effect - not sure. Could you try changing the MASTER_NAME and see if changes apply after restarting without rebuild?

I can try this at a later date. I need to catch up on 3 weeks of messages 😉

@maxpatiiuk maxpatiiuk self-requested a review June 21, 2023 04:33
@grantfitzsimmons grantfitzsimmons changed the base branch from production to v7.9-dev July 12, 2023 20:36
@grantfitzsimmons grantfitzsimmons merged commit 3ec6923 into v7.9-dev Jul 12, 2023
@grantfitzsimmons grantfitzsimmons deleted the issue-3626 branch July 12, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upon first run of Specify 7 with a Specify 6 database, an error occurrs
2 participants