-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query builder header in embedded dialog #3850
Conversation
specifyweb/frontend/js_src/lib/components/QueryBuilder/Header.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/QueryBuilder/reducer.ts
Outdated
Show resolved
Hide resolved
@specify/ux-testing when testing, please be extra careful to also test the save/save as buttons |
specifyweb/frontend/js_src/lib/components/QueryBuilder/Header.tsx
Outdated
Show resolved
Hide resolved
@maxpatiiuk all the query builder are synchronized atm, if we click Hide Mapping in one query it will be the case for all the queries. Is that what we want? |
I believe that would also be a question to ask @specify/ux-testing 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented out code
Fine with me either way. |
5c178ac
to
7f0ad0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When saving a query made in an embedded dialog (not via stats) it will prompt you to leave the current form and open the saved query in the main query builder.
It should just save the query and not show this dialog. Same applies to Save As button.
Screen.Recording.2023-09-29.at.10.03.26.AM.mov
Comments:
Embedded dialog header on stats page looks good! Switching to basic view reduces the width of the dialog, but I think this is fine.
Embedded and full query builders in sync so detailed/basic view is carried over
Decision: |
Triggered by c0e2ccb on branch refs/heads/issue-3830
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Save/Save As issue resolved.
For future reference, we could bring back the save button, or fix #3000 |
Fixes #3830