-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore usertype when searching for Common dir #4332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
c3764e2
to
268ae03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, did not get the notification with the error message.
I can't think of situations like this at the global level, but I would not endorse it. |
Implements second solution in
#3956 (comment)
Note: This will cause unexpected behavior if resources with same name appears under multiple usertypes at Global level ("Common"). I don't know if that case happens or not.
@grantfitzsimmons Have you ever seen that?
Testing instructions:
These are specific to
insectcollection_umn
database on the test panel.Create ExportFeed resource under the Global Resources, so at the top level. It is fine if the ExportFeed is empty:
Run the feed by clicking on "Create DwC Archive" in User Tools
This branch should "run" the feed (you will not get actual results till you set the feed correctly). However,
xml-editor
should give a notification with the error message saying "MissingFeedResource" somewhere in the crash report.