-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recompute taxonomic rank on parent change #4462
Conversation
Triggered by d85d301 on branch refs/heads/issue-4455
specifyweb/frontend/js_src/lib/components/PickLists/TreeLevelPickList.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/PickLists/TreeLevelPickList.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it fixed the issues within the taxon tree and when entering taxon through data entry.
@emenslin, amazing thank you! |
specifyweb/frontend/js_src/lib/components/PickLists/TreeLevelPickList.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bronwyncombs Can you test to see if this fixes #2637? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cases in issue #2637 are covered by this pr! API call in rank no longer happens - the rank field updates appropriately in response to change in parent field. Testing with Clone and Add and changing parent field also passed without issue.
Fixes #4455
and maybe #4437
Checklist
and self-explanatory (or properly documented)
Testing instructions
(examples with coldFish db)
Please test for issue 4455 and test for 4437