-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement timestamp logic #5123
Conversation
This must be tested:
|
we also don't need Line 12 in c3d0ab1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected Behavior:
- When a column within a specified table is linked to either
timestampModified
ortimestampCreated
, it should not be automatically replaced upon uploading new data. - In cases where a column is not associated with
timestampModified
ortimestampCreated
, the system should autonomously allocate both fields with the current timestamp. - When new records are generated in other tables during the same upload process, if no column is directly linked to
timestampModified
ortimestampCreated
, the system should automatically assign both fields with the current timestamp. -
timestampModified
ortimestampCreated
should be assigned the current timestamp in all cases during WorkBench uploads except when a column is mapped to that field where that row contains a valu
I worked mostly with the CO table and the Agents table and everything looks good. All cases mentioned in the expected behavior work and the timestamp modified field is now updated when a record is edited.
Ya, since we're not using the FieldTracker anymore for tracking changes in the timestamp fields, we can remove this requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When a column within a specified table is linked to either
timestampModified
ortimestampCreated
, it should not be automatically replaced upon uploading new data. - In cases where a column is not associated with
timestampModified
ortimestampCreated
, the system should autonomously allocate both fields with the current timestamp. - When new records are generated in other tables during the same upload process, if no column is directly linked to
timestampModified
ortimestampCreated
, the system should automatically assign both fields with the current timestamp. -
timestampModified
ortimestampCreated
should be assigned the current timestamp in all cases during WorkBench uploads except when a column is mapped to that field where that row contains a valu
I can confirm timestamps are being updated again for collection objects 👍 I uploaded the same data I did when comparing to edge.
The timestamps are also filled in accordingly when there is no corresponding columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When a column within a specified table is linked to either
timestampModified
ortimestampCreated
, it should not be automatically replaced upon uploading new data. - In cases where a column is not associated with
timestampModified
ortimestampCreated
, the system should autonomously allocate both fields with the current timestamp. - When new records are generated in other tables during the same upload process, if no column is directly linked to
timestampModified
ortimestampCreated
, the system should automatically assign both fields with the current timestamp. -
timestampModified
ortimestampCreated
should be assigned the current timestamp in all cases during WorkBench uploads except when a column is mapped to that field where that row contains a value
I tested on COs, agent, and locality tables, and it looks like all the timestamps are now properly updated compared to the behavior in edge 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected Behavior:
- When a column within a specified table is linked to either
timestampModified
ortimestampCreated
, it should not be automatically replaced upon uploading new data. - In cases where a column is not associated with
timestampModified
ortimestampCreated
, the system should autonomously allocate both fields with the current timestamp. - When new records are generated in other tables during the same upload process, if no column is directly linked to
timestampModified
ortimestampCreated
, the system should automatically assign both fields with the current timestamp. -
timestampModified
ortimestampCreated
should be assigned the current timestamp in all cases during WorkBench uploads except when a column is mapped to that field where that row contains a value
Looks good! Timestampmodified is also updated again when a record is modified through the data entry form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid!
Fixes #5108
Checklist
and self-explanatory (or properly documented)
Testing instructions