Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display system tables by default in query list menu option #5133

Merged
merged 8 commits into from
Jul 26, 2024
Merged

Display system tables by default in query list menu option #5133

merged 8 commits into from
Jul 26, 2024

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Jul 23, 2024 •
edited
Loading

Fixes #5128

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Go to queries
  • Click on new
  • Select the edit pencil next to new query
  • Verify Sp Audit Log - Collection - Discipline - Division show

maxpatiiuk
maxpatiiuk reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of this, should we simply make audit log tables not be system tables? that is something that is easily changeable on the back-end
there are many system tables that rightfully should remain hidden (at very least to reduce noise and confusion). there are also many sp6-only tables that we don't want to see in Sp7

@CarolineDenis
Copy link
Contributor Author

NOTES:

Should be in the query list:

  • Collection
  • Discipline
  • Division
  • SpAuditLog

@CarolineDenis CarolineDenis requested review from sharadsw, acwhite211 and a team July 24, 2024 15:28
@CarolineDenis CarolineDenis modified the milestones: 7.9.8, 7.9.7 Jul 24, 2024
@CarolineDenis CarolineDenis marked this pull request as ready for review July 24, 2024 15:29
@CarolineDenis CarolineDenis removed request for a team, acwhite211 and sharadsw July 24, 2024 15:48
emenslin
emenslin approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to queries
  • Click on new
  • Select the edit pencil next to new query
  • Verify Sp Audit Log - Collection - Discipline - Division show

Looks good, the 4 tables above now show in the query builder
Screenshot 2024-07-24 105220

combs-a
combs-a approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Go to queries
  • Click on new
  • Select the edit pencil next to new query
  • Verify Sp Audit Log - Collection - Discipline - Division show

Looks good, everything is showing and you can query just fine

image

image

Areyes42
Areyes42 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to queries
  • Click on new
  • Select the edit pencil next to new query
  • Verify Sp Audit Log - Collection - Discipline - Division show

Looks good, and they still query correctly!

maxpatiiuk
maxpatiiuk requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if this fixes the immediate bug, let's not quickly jump to creating a new list of tables - every such list we create is one more place where things can go out of date or bugs can slip in. it would be better if we can adjust the existing system to fit the new requirement, rather than add a new system as an extra layer on top...

specifyweb/specify/datamodel.py Show resolved Hide resolved
specifyweb/frontend/js_src/lib/components/SchemaConfig/Tables.tsx Outdated Show resolved Hide resolved
@CarolineDenis CarolineDenis merged commit dff3564 into production Jul 26, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-5128 branch July 26, 2024 13:38
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melton-jason melton-jason melton-jason left review comments

@emenslin emenslin emenslin approved these changes

@Areyes42 Areyes42 Areyes42 approved these changes

@combs-a combs-a combs-a approved these changes

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@grantfitzsimmons grantfitzsimmons grantfitzsimmons approved these changes

@sharadsw sharadsw sharadsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.7
Development

Successfully merging this pull request may close these issues.

Sp Audit Log no longer shows up in query builder
9 participants
@CarolineDenis @specifysoftware @sharadsw @grantfitzsimmons @maxpatiiuk @melton-jason @combs-a @Areyes42 @emenslin