Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QB Api change for handling MOTs #5251

Open
wants to merge 4 commits into
base: production
Choose a base branch
from
Open

QB Api change for handling MOTs #5251

wants to merge 4 commits into from

Conversation

acwhite211
Copy link
Member

@acwhite211 acwhite211 commented Aug 27, 2024

Fixes #4979

This should have been included in #5036 PR. This PR defines the new schema in the QB for specifying the treedefid of a rank. The new QB request schema for MOTs is <table_id>.<table_name>.<treedef_id>,<rank>,<field>. The code is backwards compatible, so it still allows that old schema to be used. The front-end needs to be changed to send this new QB request schema when dealing with MOTs.

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

TBD

@acwhite211 acwhite211 added 2 - Queries Issues that are related to the query builder or queries in general 2 - API Issues that are related to the APIs labels Aug 27, 2024
@acwhite211 acwhite211 added this to the 7.9.7 milestone Aug 27, 2024
@acwhite211
Copy link
Member Author

Still need to add front-end code to use the new API request schema when using taxon ranks.

@grantfitzsimmons
Copy link
Member

Include in 7.9.7 if front-end can be finished this week, push to 7.9.8 if not

@melton-jason melton-jason self-assigned this Aug 28, 2024
@acwhite211 acwhite211 marked this pull request as ready for review August 28, 2024 19:36
@acwhite211 acwhite211 modified the milestones: 7.9.7, 7.9.8 Aug 30, 2024
@CarolineDenis CarolineDenis modified the milestones: 7.9.8, 7.9.9 Nov 6, 2024
@CarolineDenis
Copy link
Contributor

@acwhite211
Why was this not being tested and merged?
Could you create an issue in 9.9 for it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - API Issues that are related to the APIs 2 - Queries Issues that are related to the query builder or queries in general
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

Add support for multiple trees in the query builder
4 participants