Add isLoanable only for loans when choosing record set #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarolineDenis
requested review from
a team and
maxpatiiuk
and removed request for
a team
emenslin
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Testing instructions
- Take note of your prep types and which ones are loanable or not
- Create a loan interaction
- Enter the cat number of a CO that has some prep with prep type loanable and some not loanable (or a record set that contains such CO)
- verify that only the prep with prep type loanable are proposed
- Proceed with the same flow but for another interaction, gift by example
- verify that the prep with prep type not loanable are presented as option
Looks good, if a prep is marked as not loanable it does not show up in the loan prep dialog but does show up in other interactions.
combs-a
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Testing instructions
- Take note of your prep types and which ones are loanable or not
- Create a loan interaction
- Enter the cat number of a CO that has some prep with prep type loanable and some not loanable (or a record set that contains such CO)
- verify that only the prep with prep type loanable are proposed
- Proceed with the same flow but for another interaction, gift by example
- verify that the prep with prep type not loanable are presented as option
Looks good--tested on superbotanydemo.
CarolineDenis
requested review from
melton-jason
and removed request for
acwhite211 and
maxpatiiuk
sharadsw
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5217
Checklist
and self-explanatory (or properly documented)
Testing instructions