Initial Schema Creation for Age & Stratigraphy #5274
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fields=[ | ||
| ('id', models.AutoField(db_column='AbsoluteAgeID', primary_key=True, serialize=False)), | ||
| ('absoluteage', models.DecimalField(blank=True, db_column='AbsoluteAge', decimal_places=10, max_digits=22, null=True)), | ||
| ('agetype', models.CharField(blank=True, db_column='AgeType', max_length=64, null=True)), |
There was a problem hiding this comment.
does this need to be handled like cotype and need for list creation in the migration?
There was a problem hiding this comment.
from control vocab (sedimentation, metamorphic, inclusion, original, fall,...)
grantfitzsimmons
approved these changes
Sep 19, 2024
grantfitzsimmons
requested changes
Sep 19, 2024
There was a problem hiding this comment.
-
I think we should have the tree table names follow the convention the other tree tables follow.
Current:
tectonictreedef
tectonictreedefitem
tectonicunitDesired:
tectonicunittreedef
tectonicunittreedefitem
tectonicunitThis better follows our existing convention.
-
The tables exist (yay) but the schema records do not (boo)
| @@ -18,23 +18,36 @@ | |||
| ('AbsoluteAgeAttachment', None), | |||
| ] | |||
| PICKLIST_NAME = 'AgeType' | |||
| DEFAULT_AGE_TYPES = [ | |||
There was a problem hiding this comment.
@grantfitzsimmons, can you let me know which types you would like here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5178
TODO
Checklist
and self-explanatory (or properly documented)
Testing instructions
TODO