window specific functions for ts -> rust #59
BrendonovichAnnotations
5 errors and 28 warnings
|
build (macos-latest)
Process completed with exit code 101.
|
|
build (windows-latest)
The job was canceled because "macos-latest" failed.
|
|
build (windows-latest)
The operation was canceled.
|
|
build (ubuntu-latest)
The job was canceled because "macos-latest" failed.
|
|
build (ubuntu-latest)
The operation was canceled.
|
|
used `unwrap()` on a `Result` value:
src/lib.rs#L356
warning: used `unwrap()` on a `Result` value
--> src/lib.rs:356:50
|
356 | let (invoke_handler, event_collection) = self.export_inner().unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: if you don't want to handle the `Err` case gracefully, consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
--> src/lib.rs:91:22
|
91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic
| ^^^^^^^^^^^^^^^^^^^
|
|
the borrowed expression implements the required traits:
src/event.rs#L191
warning: the borrowed expression implements the required traits
--> src/event.rs:191:21
|
191 | window.once(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
src/event.rs#L182
warning: the borrowed expression implements the required traits
--> src/event.rs:182:23
|
182 | window.listen(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
src/event.rs#L150
warning: the borrowed expression implements the required traits
--> src/event.rs:150:28
|
150 | handle.once_global(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
src/event.rs#L141
warning: the borrowed expression implements the required traits
--> src/event.rs:141:30
|
141 | handle.listen_global(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
`panic` should not be present in production code:
src/event.rs#L83
warning: `panic` should not be present in production code
--> src/event.rs:83:28
|
83 | .unwrap_or_else(|| panic!("Event {name} not found in registry!"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
|
|
the following explicit lifetimes could be elided: 'a:
src/event.rs#L56
warning: the following explicit lifetimes could be elided: 'a
--> src/event.rs:56:26
|
56 | pub fn get_or_manage<'a, R: Runtime>(handle: &'a impl Manager<R>) -> tauri::State<'a, Self> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` implied by `#[warn(clippy::all)]`
help: elide the lifetimes
|
56 - pub fn get_or_manage<'a, R: Runtime>(handle: &'a impl Manager<R>) -> tauri::State<'a, Self> {
56 + pub fn get_or_manage<R: Runtime>(handle: &impl Manager<R>) -> tauri::State<'_, Self> {
|
|
|
useless conversion to the same type: `PluginName`:
src/event.rs#L50
warning: useless conversion to the same type: `PluginName`
--> src/event.rs:50:34
|
50 | plugin_name: PluginName::from(plugin_name),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PluginName::from()`: `plugin_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` implied by `#[warn(clippy::all)]`
|
|
`panic` should not be present in production code:
src/event.rs#L34
warning: `panic` should not be present in production code
--> src/event.rs:34:13
|
34 | panic!("Another event with name {} is already registered!", E::NAME)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
|
|
`panic` should not be present in production code:
src/event.rs#L30
warning: `panic` should not be present in production code
--> src/event.rs:30:13
|
30 | panic!("Event {} registered twice!", E::NAME)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
note: the lint level is defined here
--> src/lib.rs:91:43
|
91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic
| ^^^^^^^^^^^^^
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/ts.rs#L171
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/ts.rs:171:63
|
171 | .map(|v| ts::export_named_datatype(&cfg.inner, v, &type_map))
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/ts.rs#L166
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/ts.rs:166:50
|
166 | let events = Self::render_events(events, &type_map, cfg)?;
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/ts.rs#L165
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/ts.rs:165:56
|
165 | let commands = Self::render_commands(commands, &type_map, cfg)?;
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/ts.rs#L59
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/ts.rs:59:57
|
59 | ... ts::datatype(&cfg.inner, e, &type_map)?
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/ts.rs#L50
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/ts.rs:50:54
|
50 | t => ts::datatype(&cfg.inner, t, &type_map)?,
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/ts.rs#L48
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/ts.rs:48:53
|
48 | ts::datatype(&cfg.inner, t, &type_map)?
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/ts.rs#L38
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/ts.rs:38:55
|
38 | ts::datatype(&cfg.inner, typ, &type_map)
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`:
src/ts.rs#L28
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
--> src/ts.rs:28:14
|
28 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/js.rs#L185
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/js.rs:185:51
|
185 | ts::named_datatype(&cfg.inner, v, &type_map).map(|typ| {
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/js.rs#L179
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/js.rs:179:50
|
179 | let events = Self::render_events(events, &type_map, cfg)?;
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/js.rs#L178
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/js.rs:178:56
|
178 | let commands = Self::render_commands(commands, &type_map, cfg)?;
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/js.rs#L131
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/js.rs:131:38
|
131 | .apply_as_prefix(&event.name, ItemType::Event);
| ^^^^^^^^^^^ help: change this to: `event.name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/js.rs#L50
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/js.rs:50:59
|
50 | ... ts::datatype(&cfg.inner, typ, &type_map).map(|typ| {
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/js.rs#L43
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/js.rs:43:58
|
43 | t => ts::datatype(&cfg.inner, t, &type_map)?,
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/js.rs#L40
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/js.rs:40:61
|
40 | ... ts::datatype(&cfg.inner, e, &type_map)?
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/js.rs#L39
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/js.rs:39:61
|
39 | ... ts::datatype(&cfg.inner, t, &type_map)?,
| ^^^^^^^^^ help: change this to: `type_map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`:
src/js.rs#L30
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
--> src/js.rs:30:14
|
30 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
note: the lint level is defined here
--> src/lib.rs:91:9
|
91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic
| ^^^^^^^^^^^
= note: `#[warn(clippy::into_iter_on_ref)]` implied by `#[warn(clippy::all)]`
|
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|