feat!: add a way to specify a plugin name #32

Suyashtnt · 2023-08-29T15:43:47Z

This refactors the config option to allow for custom plugin names for people who want to use this tool with a plugin

BREAKING: This completely changes the configuration Struct into a custom one

This also adds a flake.nix with a devshell for NixOS users. Not sure if that should also be in this PR

This refactors the config option to allow for custom plugin names for people who want to use this tool with a plugin BREAKING: This completely changes the configuration Struct into a custom one

src/lib.rs

src/ts.rs

src/lib.rs

oscartbeaumont

Thanks heaps for this PR!

Have left some comments which should be pretty easy to resolve and then we can ship this to the v2 branch.

I would also prefer if the nix stuff isn't committed to the repo.

Suyashtnt · 2023-08-29T16:16:01Z

I would also prefer if the nix stuff isn't committed to the repo.

Should I rather add that in a seperate PR? Once LGTM you can remove the flake.nix, flake.lock, and .envrc files along with the .direnv/ entry in the gitignore

Added methods for changing the plugin name and specta config

…ring For consistency and to allow non-heap-allocated strings

oscartbeaumont · 2023-08-29T16:29:19Z

I would rather just remove the Nix-related files before merging this PR! Nix is very cool but I don't use it and from my understanding, it isn't used widely enough for it to be worth adding extra clutter to the root of the repo.

Suyashtnt · 2023-08-29T16:30:20Z

I would rather just remove the Nix-related files before merging this PR! Nix is very cool but I don't use it and from my understanding, it isn't used widely enough for it to be worth adding extra clutter to the root of the repo.

What I meant is remove the files before the merge but first make sure the rest is alright.

oscartbeaumont

Thanks for the changes but left a few more comments.

Sorry, I misread your last message. Happy to keep the Nix stuff until the PR is ready to merge!

src/lib.rs

oscartbeaumont

Thanks for all the fixes. Just that one more fix and it should be good.

src/ts.rs

oscartbeaumont · 2023-08-29T17:22:07Z

Remove the nix files and I am happy to merge this into the v2 branch.

I am going to hold off doing a release until I finish some more work on Specta's next release candidate and release it. You should be able to safely lock to a Git commit for now, but be aware you will want to use specta = "=2.0.0-rc.1" in your project when using the tauri_specta v2 branch.

oscartbeaumont · 2023-08-29T17:22:32Z

Thanks heaps for your contribution. This has come up before and is very needed feature!

Suyashtnt added 2 commits August 29, 2023 17:42

feat!: add a way to specify a plugin name

a26675e

This refactors the config option to allow for custom plugin names for people who want to use this tool with a plugin BREAKING: This completely changes the configuration Struct into a custom one

fix: remove default features added during dev

30c17ab