custom plugin example #67
clippy
9 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 9 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.0 (5680fa18f 2023-08-23)
- cargo 1.72.0 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (5680fa1 2023-08-23)
Annotations
Check warning on line 354 in src/lib.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> src/lib.rs:354:50
|
354 | let (invoke_handler, event_collection) = self.export_inner().unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: if you don't want to handle the `Err` case gracefully, consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
--> src/lib.rs:91:22
|
91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic
| ^^^^^^^^^^^^^^^^^^^
Check warning on line 211 in src/event.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/event.rs:211:21
|
211 | window.once(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 201 in src/event.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/event.rs:201:23
|
201 | window.listen(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 159 in src/event.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/event.rs:159:28
|
159 | handle.once_global(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 149 in src/event.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/event.rs:149:30
|
149 | handle.listen_global(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
Check warning on line 81 in src/event.rs
github-actions / clippy
`panic` should not be present in production code
warning: `panic` should not be present in production code
--> src/event.rs:81:28
|
81 | .unwrap_or_else(|| panic!("Event {name} not found in registry!"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
Check warning on line 54 in src/event.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> src/event.rs:54:26
|
54 | pub fn get_or_manage<'a, R: Runtime>(handle: &'a impl Manager<R>) -> tauri::State<'a, Self> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
note: the lint level is defined here
--> src/lib.rs:91:9
|
91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic
| ^^^^^^^^^^^
= note: `#[warn(clippy::needless_lifetimes)]` implied by `#[warn(clippy::all)]`
help: elide the lifetimes
|
54 - pub fn get_or_manage<'a, R: Runtime>(handle: &'a impl Manager<R>) -> tauri::State<'a, Self> {
54 + pub fn get_or_manage<R: Runtime>(handle: &impl Manager<R>) -> tauri::State<'_, Self> {
|
Check warning on line 34 in src/event.rs
github-actions / clippy
`panic` should not be present in production code
warning: `panic` should not be present in production code
--> src/event.rs:34:13
|
34 | panic!("Another event with name {} is already registered!", E::NAME)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
Check warning on line 30 in src/event.rs
github-actions / clippy
`panic` should not be present in production code
warning: `panic` should not be present in production code
--> src/event.rs:30:13
|
30 | panic!("Event {} registered twice!", E::NAME)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
note: the lint level is defined here
--> src/lib.rs:91:43
|
91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic
| ^^^^^^^^^^^^^