Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsEmpty() checks were missing before some SwitchMemtable() invocation… #808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pranavshenoy
Copy link

Bug: facebook/rocksdb#12179

There was one instance where the IsEmpty() check was missing:

rocksdb/db/db_impl/db_impl_write.cc

Line 1706 in 21d5a8f

status = SwitchMemtable(cfd, write_context);
Having one check inside SwitchMemTable() will ensure there won't be misses in the future.

@ofriedma ofriedma self-requested a review January 23, 2024 08:58
Copy link
Contributor

@ofriedma ofriedma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavshenoy thank you for your contribution.
Currently there are some tests that are failing with this code changes, that should be addressed before merging.

4550 - DBTest.DeletingOldWalAfterDrop (Failed)
12804 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, false, 1, 0) (Failed)
12805 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, true, 1, 0) (Failed)
12806 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, true, 1, 1) (Failed)
12807 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, false, 2, 0) (Failed)
12808 - DBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(false, true, 2, 0) (Failed)
13294 - StackableDBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(true, true, 1, 0) (Failed)
13295 - StackableDBAsBaseDB/TransactionTest.TwoPhaseEmptyWriteTest/(true, true, 2, 0) (Failed)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


PRANAV SHENOY seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants