2.2 develop-update #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-not-work-for-configurable-products. Use configurable product`s children for shopping cart rules validation for cases when attribute exists for children only (E.g. special_price)
…-not-work-for-configurable-products. Revert "Removed dependency to configurable product" This reverts commit d2a0de8.
…-not-work-for-configurable-products. Made getProductToValidate method private according to Technical Guideline (2.7)
…-not-work-for-configurable-products. Added configurable product to dependencies
…ice-does-not-work-for-configurable-products. Added configurable product to dependencies" This reverts commit 887ee4a
…ondition-over-special-price-does-not-work-for-configurable-products # Conflicts: # app/code/Magento/SalesRule/Model/Rule/Condition/Product.php
…-not-work-for-configurable-products. Restored \Magento\SalesRule\Model\Rule\Condition\Product to its previous state except PHPDocs.
…-not-work-for-configurable-products Removed an empty line.
…Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products
…ted-condition-over-special-price-does-not-work-for-configurable-products' into #14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products
…-not-work-for-configurable-products. Unit tests coverage: case when child should be used
…-not-work-for-configurable-products. Fixed mock objects comparison
…-not-work-for-configurable-products. Fixed static tests.
…Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products
…al-price-does… #16342 - Merge Pull Request #16342 from novikor/magento2:#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products - Merged commits: 1. 90b6803 2. 2717cb1 3. d2a0de8 4. fae98c0 5. 9a35b45 6. 887ee4a 7. 0c9aa81 8. 4e68337 9. 5b95b22 10. 618f408 11. 7c8482b 12. e7130bf 13. 5a7e78a 14. 8d417ac 15. 90ff989 16. c52e0e8 17. 5c3154b 18. 51adb9d
- fixed docblocks
…e is checkbox and add to cart with 3 values only 2 values added to cart. #19260
Accepted Public Pull Requests: - #19260: Issue #19205 Fixed: Bundle Product Option with input type is checkbox and add to cart with 3 values only 2 values added to cart. (by @maheshWebkul721) - #19237: [Backport] #18956 Fixes for set root_category_id (by @gelanivishal) - #19240: [Backport] Add missing unit test for WishlistSettings plugin (by @gelanivishal) - #19216: [Backport] Covering the \Magento\Weee observers by Unit Tests (by @eduard13) - #19217: [Backport] Covering the CheckUserLoginBackendObserver by Unit Test (by @eduard13) - #18808: fixed Quote Item Prices are NULL in cart related events. #18685 (by @ashutoshwebkul) - #16342: #14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does� (by @novikor) Fixed GitHub Issues: - #19205: Bundle Product Option with input type is checkbox and add to cart with 3 values only 2 values added to cart (reported by @sneha-panchal) has been fixed in #19260 by @maheshWebkul721 in 2.2-develop branch Related commits: 1. aa379ea 2. 1a321d2 - #18956: Import of RootCategoryId should be possbile (Magento/Store/Model/Config/Importer/Processor/Create.php) (reported by @larsroettig) has been fixed in #19237 by @gelanivishal in 2.2-develop branch Related commits: 1. aa4abec 2. acefdb3 3. 5866a39 4. fee2712 5. 7be21e2 - #18685: Quote Item Prices are NULL in cart related events. (reported by @qsolutions-pl) has been fixed in #18808 by @ashutoshwebkul in 2.2-develop branch Related commits: 1. 09586e4 2. 1638891 3. 175ebc0 4. 59bd874 - #14020: Cart Sales Rule with negated condition over special_price does not work for configurable products (reported by @Filipe-Bicho) has been fixed in #16342 by @novikor in 2.2-develop branch Related commits: 1. 90b6803 2. 2717cb1 3. d2a0de8 4. fae98c0 5. 9a35b45 6. 887ee4a 7. 0c9aa81 8. 4e68337 9. 5b95b22 10. 618f408 11. 7c8482b 12. e7130bf 13. 5a7e78a 14. 8d417ac 15. 90ff989 16. c52e0e8 17. 5c3154b 18. 51adb9d
speedy008
pushed a commit
that referenced
this pull request
Feb 15, 2019
Magento 2.3-develop Latest Pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)